Not sure but I think CE “no” i.e. vs “ng”,“ne” is slated for these devices as well once it gets up and running - and that is on newer AMLogic stack I understand - maybe they sorted out some of this already, fingers crossed.
Yes, many thanks! At first sight, the conversion is of very high quality.
1 Like
What about adding an option to toggle VS10 to the Video Settings that you can access from the Setting menu while playing a video so that users can experiment with it and solve issues when VS10 is not enabled?
@cpm will test v4 over the weekend and let you know how i goes.
The best succes have been when i set force 12 bit 422 in Kodi gui . Auto would give me green / pink colors . With 12bit 422 that issue is gone.
Only minor issue is that some times after playback the color of gui gets a litte dim/ less colorfull . Maybe that issue would be solved if you could get gui also to be lldv ?
For live tv plackback that would be great to not have resolution change for quicker start. V1 was the best for live tv . But v1 had issues with my 2 hdr files .
Edit for v4 black screen /only audio on hdr files is back. Reverting to v3 (20240428) they play fine in lldv again
first results, am6 vs10 hdr to dv with edid LG C2. Video HDR table 4000. am6 wins over dune 8k. Dune’s brightness was out of bounds due to over sharpening, am6 did tonemapping more accurately. Color gradients are also better with am6, but I think that’s because of the over-sharpening
1 Like
The existing behavior in the tonemap HDR option in CE just renders everything including GUI in HDR.
Maybe you can take a similar approach with VS10 DV rather than the more convoluted start/stop logic where it tries to auto set the display mode and switch in/out of DV. As you say, has timing complication.
Rendering everything maybe more robust, easier, and consistent with the behavior of existing HDR tonemapping option. The existing players on the market (Zidoo and Dune) also do not engage VS10 on start/stop. Maybe because of similar technical challenges that you’re seeing.
1 Like
This is looking great, can’t wait till my machine arrives to try it 
I have shared this POC code with the CoreELEC team for the CE team to take this forward in the most appropriate manner for them, thanks for all the testing!
1 Like
This is gearing up to be an amazing weekend or week. Thank you!
@cpm can you make a v5 with dv. Iso ? 
I think it is still being worked on by Portisch from the CE team - some issues with MEL - give it a day or two and then when I get some time will create a new version.
1 Like
Can someone try this file, it plays fine on firestick 4k max in dolby vision via kodi-quietvoid p7 to p8. But gets black screen on ce&vs10.
Hi cpm, will the feedback and updates continue in this thread or will the CE Team start a new thread? Thank you.
I’ve mentioned this before with the bit setting issues happening earlier with DV.
In relation to this effort I have to agree on its relevance here as well. Best I can tell in the AMlogic original driver, the set_disp_mode_auto method was coded to only process refresh rates and resolution. It didn’t also handle CD/CS logic. So while it mostly works currently, the driver wasn’t designed to work this way.
Unfortunately I didn’t quite nail down an alternate spot in the driver code. But I suspect it’s also in hdmi_tx_hw.c
Also I have a Dune Boxy running stock android tv 11. While it has a S905X4 SoC, I’m pretty sure it ultimately shares a lot of commonality with the Ugoos. Ironically you are forced to either set DV always on for TV led to get complete playback for supported formats (ie setting adaptive HDR meant HDR10 would play in SDR only), or for player led, adaptive HDR was possible (since the same CD/CS settings work for both LLDV and HDR10). Basically the box just wouldn’t do CD/CS switching and forced settings to not have to deal with it. Given the behavior described here so far, I’m not surprised the Boxy is doing this. Then on top of it, the VC-1 limitations, even…
I’m curious what the Fire TV code looks like for the 2nd gen cube. Maybe we can review to gather clues? Its closer to the behavior we’re after.
But don’t recall seeing an easily reviewable source.
When / if the CE team want to take this up I am sure they will communicate if they need feedback etc. and where that would be.
This testing proves that these SoC with the Dolby extension are VS10 and the AMLogic code supports these types of conversions and the results are very good when paired with the correct settings.
There are some hurdles to make this work with flawless execution but they don’t feel insurmountable and can get a 90% good experience already.
Personally, I don’t think that looking at other Fire TV code would be that helpful. If I was to do it, I would just delete and redo that part of the code - to me, I seems way more complicated and dependent on what the previous setting were then necessary. I mean one of those function about setting the avi packet I found doesn’t actually seem to do anything aside from setting a buffer that is then ignored.
My approach for a rock-solid redo would be to pass some info about the file being played down from Kodi, and then just set everything (resolution, cd, cs, avi packet, vsif’s, etc) once based on that.
v5.
- Bug fixes
- Rebased on latest CoreELEC 21
Edit: Version removed - please see new version in later post.
@Jonke This should include the DTDL upgrades from the nightly.
Please do let me know how the test with DV → HDR10 went with your projector.
3 Likes
Tested - tv-led - and working fine for all mappings for me:
DV → DV (I.e. no mapping DV as per normal)
DV → HDR10
DV → SDR10
DV → SDR8
2 Likes
The DV in HDR doesn’t work as it should, it just outputs without tonemapping the HDR layer. I.e. if the file is DV PQ4000, even if edid with 800 nit, it just outputs HDR layer with original PQ4000.
DV in SDR, HDR in SDR works well.
DV 5 profile is output with original PQ1000, also without tonemapping for TV capabilities