Help with CEC commands (N2)

Portisch · 5 January 2021 22:31

I just checked it a bit and it’s definitely broken.

So I checked my settings before changing physical address:

I changed it to just like 3. After OK I lost CEC connection and when I re-enter the options look now:

The options changed! Now I am able to set the HDMI port number and it’s set to default 1.

I see on my TV Kodi is now on HDMI1, but in “real” it’s on HDMI3. So I changed the HDMI port to 3 and CEC is working again now, physical address is still 0.

Ok, but now the next issue:

github.com

CoreELEC/xbmc/blob/amlogic-4.9-18.9/xbmc/peripherals/devices/PeripheralCecAdapter.cpp#L1211-L1220


// set the physical address, when baseDevice or iHDMIPort are not set
std::string strPhysicalAddress("0");
if (!bPAAutoDetected && (m_configuration.baseDevice == CECDEVICE_UNKNOWN ||
    m_configuration.iHDMIPort < CEC_MIN_HDMI_PORTNUMBER ||
    m_configuration.iHDMIPort > CEC_MAX_HDMI_PORTNUMBER))
{
  m_configuration.iPhysicalAddress = config.iPhysicalAddress;
  strPhysicalAddress = StringUtils::Format("%x", config.iPhysicalAddress);
}
bChanged |= SetSetting("physical_address", strPhysicalAddress);

bPAAutoDetected is false, OK
m_configuration.baseDevice is NOT CECDEVICE_UNKNOWN -> useless
m_configuration.iHDMIPort < CEC_MIN_HDMI_PORTNUMBER -> useless
m_configuration.iHDMIPort > CEC_MAX_HDMI_PORTNUMBER -> useless

CEC_MIN_HDMI_PORTNUMBER is 1,
CEC_MAX_HDMI_PORTNUMBER is 15

The user is not able to set a number smaller then 1 or higher than 15.
So strPhysicalAddress("0") will be set every time as the condition is never met.

I guess this is wrong:

github.com

CoreELEC/xbmc/blob/amlogic-4.9-18.9/xbmc/peripherals/devices/PeripheralCecAdapter.cpp#L1278


    iDeviceType != (int)CEC_DEVICE_TYPE_PLAYBACK_DEVICE &&
    iDeviceType != (int)CEC_DEVICE_TYPE_TUNER)
  iDeviceType = (int)CEC_DEVICE_TYPE_RECORDING_DEVICE;
m_configuration.deviceTypes.Add((cec_device_type)iDeviceType);
// always try to autodetect the address.
// when the firmware supports this, it will override the physical address, connected device and hdmi port settings
m_configuration.bAutodetectAddress = CEC_DEFAULT_SETTING_AUTODETECT_ADDRESS;
// set the physical address
// when set, it will override the connected device and hdmi port settings
std::string strPhysicalAddress = GetSettingString("physical_address");
int iPhysicalAddress;
if (sscanf(strPhysicalAddress.c_str(), "%x", &iPhysicalAddress) &&
    iPhysicalAddress >= CEC_PHYSICAL_ADDRESS_TV &&
    iPhysicalAddress <= CEC_MAX_PHYSICAL_ADDRESS)
  m_configuration.iPhysicalAddress = iPhysicalAddress;
else
  m_configuration.iPhysicalAddress = CEC_PHYSICAL_ADDRESS_TV;
// set the connected device

If iPhysicalAddress is set by user m_configuration.iHDMIPort need to be set to 0 (CEC_HDMI_PORTNUMBER_NONE), then it should work. Then iPhysicalAddress get higher priority over iHDMIPort. libCEC check first by else if HDMI port set, then afterwards by else if physical address is set. So this will never be hit if HDMI port is set to 1 - 15:

github.com

Pulse-Eight/libcec/blob/master/src/libcec/CECClient.cpp#L943-L955


else if (
  configuration.baseDevice != CECDEVICE_UNKNOWN &&
  configuration.iHDMIPort > 0 &&
  configuration.iHDMIPort <= 0xF)
{
  // set the configured device+port
  SetHDMIPort(configuration.baseDevice, configuration.iHDMIPort);
}
else
{
  // set the physical address
  SetPhysicalAddress(configuration);
}

Physical addresses are valid from 0x1000 - 0xFFFE.
The TV would be 0000, my device connected to HDMI port 3 should be then: 3000 by this description: https://elinux.org/images/d/d9/Verkuil.pdf

Physical Address
Physical address: Hierarchy placement
Range: 0.0.0.0 - F.F.F.F
Root device: 0.0.0.0: HDMI Sink, typically a TV
First device: 1.0.0.0: Device connected to HDMI port 1 on root device
Second device: 2.0.0.0: Device connected to HDMI port 2 on root device
Third device: 1.1.0.0: Device connected to HDMI port 1 on first device

Or another example:
0x2200 is [TV] -> HDMI 2 -> [AVR] -> HDMI 2 -> [CE DEVICE]

I will need to check it in more detail the next days.