Kodi Audio Out of Sync playing file or after seeking

General
243

To make things clearer, at least to me, what’s the future here?

What the next nightly/release will be featured with?

  • The advancedsettings.xml tweak for audio delay based on resolution?
  • The script.audiooffsetmanager?
  • Both?

If the future is only script.audiooffsetmanager, how can I simply transpose my config strId=2160p24hz and delay=250 in the addon?

I haven’t tested it yet but from the screenshots, it seems I’d need to somehow duplicate the delay in all audio formats or can I set a global setting affecting all audio formats?

244

I can only speak about the addon, but the addon does not take into account resolution (rather HDR type, audio format, and FPS of source video instead). I think the ideal solution would be if Portisch’s new advanced setting for delay based on resolution is added into the codebase, and then for people that need more control they can install the addon once it’s added to either Kodi or CE repo. So, I think a combination of both would be the ideal solution. That’s my outside opinion.

1 Like
245

The advanced settings tweak delay by resolution should be supported since 20241129. In CE-22 there is also a additional delay tweak if media is HDR: hdrextradelay. But for full support of this new parameter GetOSHDRStatus need to be implemented first.

4 Likes
246

@Portisch With those commits over the last few days are all the fixes from your test image now on github?

247

Yes, nightly have all latency fixes what are possible since 20241129.
Other things like different latency for HDR must be adjusted by users.

1 Like
248

Is the following still the case in the 20241129 nightly?

If so, could you point out where in the code that is / what the work around you tried in the test build in Kodi Audio Out of Sync playing file or after seeking - #189 by Portisch was? I’d like to have a look at it

249

No, this was not changed as I guess it’s good to start adjusting when ±2 frames and not on ±1 frame as it will lead to lot of picture stuck visible.
The “bug” is here:

It only skip frames when m_queued.front() != idx. But when one frame is late it’s m_queued.front() == idx and it does not skip it.

1 Like
250

so, with the latest changes in the nightly the delay tweaks (when/if required) are in the advancedsettings.xml and not via the audiooffsetmanager addon, right?

251

Both options are available.

1 Like
252

@Portisch

Based on RenderManager: CheckEnableClockSync: Don't do a vsync adjust on perfe… · CoreELEC/xbmc@da09b59 · GitHub should m_clockSync.m_enabled = false, and following that VSyncOff = 0.0 (in the debug window), if the video file and output frame rates match?

On the nighties I’m seeing a nonzero value for VSyncOff for fractional frame rates. This was not the case in older versions of CE.

Going through the code, it looks like that is occurring because fps = 23.976025… and GetFPS() = 23.976023… leading to diff = ~8.3e-8. This obviously evaluates to true as no numeric tolerance is being used despite being below the tolerance for single precision calculations with both fps and GetFPS() being floats.

Is this the intended behaviour?

253

No idea, it’s very very old:

254

3 posts were merged into an existing topic: Help, support CPM build

255

I’m currently using 21.1.1-Omega_nightly_20241129 and all is perfect, the advancedsettings.xml tweak work like charm.

Again, thank you @Portisch!

256

For a vanilla setup of box connected directly to TV. Is there a ‘default’ advancedsettings.xml that everyone should use?

I see in previous comments that there is a consistent 3-4 frame delay in 2160p content.

257

I don’t know if the following settings are relevant to your setup and/or use case but here are the settings I personally use:

    <video>
        <latency>
            <resolution>
                <strId>2160p24hz</strId>
                <delay>250</delay>
            </resolution>
        </latency>
    </video>

With this, on my DuneHD/Homatics Box R 4K, everything works perfectly in 4K/24Hz movies and audio is now in sync. YMMV.

1 Like
258

Good question. Maybe @Portisch can help out here.

259

Yeah, as a relatively new CE user on an AM6B+, I’d certainly appreciate the quick bullet guide on what the “right” thing is to do to get the audio sync lined up. I’m a bit unclear from reading this thread as to whether the issue is now basically fixed (if I’m on 11/29 CE Nightly), or whether I should be doing some sort of manual edits to advancedsettings.xml (the latter leading to “how?”, but I’ll research/cross that bridge when I get to it!) Thank you!

1 Like
260

Ok, but I was more asking about your change that went from if (diff < 0.0005) to if (diff && diff < 0.0005) with the comment “Don’t do a vsync adjust on perfect match”.

For a fractional 24 fps video on played on CE with a fractional 24 fps output, did you intend to set m_clockSync.m_enabled = true or not?

261

The fix to remove the default audio lag of four frames has not been included into the nightly.

By default everyone will need to make a advancedsettings.xml to correct this error and then adjust from there as needed. When doing so will also need to account for CE not using native refresh rates but doing frame doubling for some, but not all, refresh rates.

262

Understood, but only for 4K resolutions right? I saw that someone mentioned here all 1080p content is in sync.

Until that is incorporated into nightly, an advancedsettings.xml with every 4K resolution and refresh rate combo, and the resulting calculation from here:

(3+1)/[FRAMERATE] = delay * -1