Ability to sort by original title

JimmyS · 16 March 2021 12:21

Most of (newer) scrapers (such as default tmdb) supports wraping item Title in user’s choice language. And they are able to store also original name into originaltitle variable (infolabel).

It could be displayed by skin in lists, etc. User can choose, which title he wants in lists, dynamically, even both of them for example.

The problem is, that Kodi lacks function to sort list according that title. It supports only Title, and Sorttitle parameters. Sorttitle is written to DB during scraping, so its not dynamic parameter at all.

I added this SortbyOriginalTitle function to Kodi (using 18 at this time, due to GXBB platform). I know, that this should go to the Kodi, and I will try create PR there eventually, but looking on Issues they have quite a full hands with Matrix, I would guess this will take significant amount of time to pull out.

My question is: would you be willing include this to the CE’s xbmc, if I create PR against CE’s xbmc? Or could be added like temporary patch, but this would be more suitable for 18 branch, since 19 is very active and patch would be possible needed to correct in future.

Example on dummy data: https://streamable.com/kgvjj9

Portisch · 16 March 2021 13:10

Best would be you make a PR to xbmc/master. We can then temporary pick the PR until it get (maybe) merged.

JimmyS · 16 March 2021 15:15

Thanks. Fingers crossed.

xbmc 18 https://github.com/xbmc/xbmc/pull/19434
xbmc 19 https://github.com/xbmc/xbmc/pull/19435

JimmyS · 18 March 2021 08:57

So far it works fine for me on Win32/Amlogic/Amlogic-ng… The 18 branch PR was closed, it will be maybe backported or not (they dont backport features usually). 19 branch is now in pending room

I added also sortmetod into JSON call, after 19434 was closed, so there is missing one commit, if you would decide to pick that one for Leia at some point. PR against master should be complete I believe.

If anyone would like to have this, or wants to take a quick peek, here is patch for Leia branch.

JimmyS · 25 March 2021 12:09

Seems it will not be in upstream until Kodi 20.

@Portisch Feel free to cherrypick those into Leia/Matrix branches

Portisch · 29 May 2021 17:29

We have it already a long time in Matrix.

Do I need to update the patch @JimmyS ?

github.com

CoreELEC/CoreELEC/blob/coreelec-19/projects/Amlogic-ce/devices/Amlogic-ng/patches/kodi/kodi-temp-05-Sort_function_by_Original_title_SortByOriginalTitle.patch

From 4323ae6bdec1053748230efa27b41ceca56b8559 Mon Sep 17 00:00:00 2001
From: JimmyS83 <github.jpeter@spamgourmet.com>
Date: Tue, 16 Mar 2021 15:55:13 +0100
Subject: [PATCH] Sortybyoriginaltitle

---
 xbmc/FileItem.cpp                         |  1 +
 xbmc/SortFileItem.h                       |  4 +++-
 xbmc/filesystem/PluginDirectory.cpp       |  6 ++++++
 xbmc/interfaces/legacy/ModuleXbmcplugin.h |  2 ++
 xbmc/playlists/SmartPlayList.cpp          |  3 +++
 xbmc/utils/SortUtils.cpp                  | 23 +++++++++++++++++++++++
 xbmc/utils/SortUtils.h                    |  2 ++
 xbmc/video/GUIViewStateVideo.cpp          |  5 +++++
 xbmc/video/VideoDatabase.cpp              |  3 ++-
 xbmc/video/VideoInfoTag.cpp               | 10 ++++++++++
 10 files changed, 57 insertions(+), 2 deletions(-)

diff --git a/xbmc/FileItem.cpp b/xbmc/FileItem.cpp
index 4f8539e304d7..5f83d668704e 100644

This file has been truncated. show original

Edit: I just saw you still have formatting issues in the PR. Please correct them that I can update the patch in CoreELEC, thank you.

JimmyS · 29 May 2021 17:57

Ah, I didnt didnt noticed that (I am on 9.2 due to C2 hardware), I didnt noticed it on 9.2 branch so I assumed it wasnt included at all

The formatting should be already solved, I think that second automated Jenkins response was caused due build, which was automatically planned before I appled/commited requested changes and finishes after submit.

Portisch · 31 May 2021 08:07

Thank you, I updated the patch in CE.

Please remind the api version did change and your patch does not apply anymore:

github.com/xbmc/xbmc

[JSON]Add sort video items by original title - SortByOriginalTitle

xbmc:master ← JimmyS83:sort_original_title_v19

opened 03:08PM - 16 Mar 21 UTC

JimmyS83

+139 -79

This is Matrix version of a (now closed) PR originally submitted for Leia - http…s://github.com/xbmc/xbmc/pull/19434 ## Description Adds sort method, according `originaltitle` variable/infolabel, with fallback to standard `sorttitle`, `title`. ## Motivation and Context Most of (newer) scrapers (such as default tmdb) supports scraping item `Title` in user’s choice language. They are able to store also original title into `originaltitle` variable (infolabel). It could be displayed by skin in lists, etc. User can choose, which title he wants in lists, dynamically, even both of them for example. The problem is, that Kodi lacks function to sort list according originaltitle. It supports only `Title`, and `Sorttitle` parameters. `Sorttitle` is written to DB during scraping, so its not dynamic parameter at all. ## How Has This Been Tested? ## Screenshots (if appropriate): Example on dummy data, where both titles are visible to make a point more easilly: https://streamable.com/kgvjj9 ## Types of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality) - [X] **Improvement** (non-breaking change which improves existing functionality) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that will cause existing functionality to change) - [ ] **Cosmetic change** (non-breaking change that doesn't touch code) - [ ] **None of the above** (please explain below) ## Checklist: - [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project - [ ] My change requires a change to the documentation, either Doxygen or wiki - [ ] I have updated the documentation accordingly - [X] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document - [X] I have added tests to cover my change - [X] All new and existing tests passed

It’s already 12.3.0 now. So I changed it to patch from 12.3.0 to 12.3.1.

Portisch · 30 July 2021 08:26

@JimmyS what about the JSON API version?
Every time I rebase XBMC and the JSONRPC_VERSION is changed the patch fails.
Is it really needed to bump the JSONRPC_VERSION or can it be excluded from the patch?

JimmyS · 30 July 2021 11:02

well, to be honest I dont have that deep understanding of project, but if I remember corectly, Kodi team requested JSON coverage in original PR, as I didnt include it in first draft.

For the patch purposes, I dont think that version number is needed to track, and when they include this PR, the patch wouldnt be needed at all (at least for the next Kodi version) ? However, the working code for JSON call could be usefull for someone.