I was wondering if it would be possible to implement something like this in CoreELEC:
xbmc:master
← thexai:android-gui-sdr-peak
opened 06:18PM - 24 Feb 24 UTC
## Description
[Android] Adjust GUI SRD peak luminance when display is in HDR P… Q mode
This the equivalent functionality of https://github.com/xbmc/xbmc/pull/18984 and https://github.com/xbmc/xbmc/pull/21973 for Android.
## Motivation and context
This is requested a lot on the forums....
https://forum.kodi.tv/showthread.php?tid=376360
https://forum.kodi.tv/showthread.php?tid=357205
https://www.reddit.com/r/kodi/comments/1awb6h3/osd_hdr_too_bright_during_playback/
With this is not necessary set subtitles color dark grey or different color for SDR / HDR and also is adjusted OSD and all GUI elements.
Android already does basic tone mapping - there is no need for full tone mapping from BT.709 to BT.2020 or gamma to PQ transfer. Only is need to set the SDR peak to 100 or 200 nits because by default it seems to be set to 1000 nits (at least in Shiled) and this is why it looks much brighter than normal SDR.
When SDR peak is set to 100 - 200 nits then GUI has same appearance than in SDR and GUI white is regular SDR white.
The default setting is 40% and matches what we already have in Windows. That is, the result is consistent with Windows using the same setting value. Adjusting GUI setting to 100% gives you the maximum brightness (~1000 nits), which is the same as before this PR.
## How has this been tested?
Runtime Shield Pro 2019
Forum users:
- Fire TV Stick 4K Max 2nd gen (https://forum.kodi.tv/showthread.php?tid=376360&pid=3186614#pid3186614)
- Fire TV Stick 4K Max 1st gen (https://forum.kodi.tv/showthread.php?tid=376360&pid=3186768#pid3186768)
## What is the effect on users?
No more tricks to adjust brightness of subtitles / OSD / GUI when playing HDR10 or Dolby Vision contents.
## Screenshots (if appropriate):
![screenshot00001](https://github.com/xbmc/xbmc/assets/58434170/a54bfe70-f129-49b1-82fa-17f282367ec0)
## Types of change
- [ ] **Bug fix** (non-breaking change which fixes an issue)
- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)
- [ ] **Improvement** (non-breaking change which improves existing functionality)
- [X] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)
- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)
- [ ] **Student submission** (PR was done for educational purposes and will be treated as such)
- [ ] **None of the above** (please explain below)
## Checklist:
- [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project
- [ ] My change requires a change to the documentation, either Doxygen or wiki
- [ ] I have updated the documentation accordingly
- [X] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document
- [ ] I have added tests to cover my change
- [ ] All new and existing tests passed
This PR is meant for Android. It will reduce the brightness of the OSD and subtitles when an HDR or DV video is being played. Any chance something similar could be implemented on the Amlogic devices?
Hi, its feature working fine under android, its part of kodi omega.
The subtitles and the GUI, user choice, can reduce the brighness in hdr/dv mode in those elements.
Would be nice when that would be possible under CoreElec too…
Forgot to post this here, but this can be achieved by adding this to your autostart.sh:
echo 200 > /sys/module/amdolby_vision/parameters/dolby_vision_graphic_max
This will limit the brightness of the OSD and subtitles to 200 nits.
Unfortunately it cannot be done in the GUI (and doesn’t work for HDR, only DV).
1 Like
Must the luminance controlled also in HDR10(+) or only when DV mode?
EDIT:
The feature will be included in nightly since 20240522 CE-21/22 for DV.
2 Likes
In the Android version, the luminance setting works for both HDR10(+) and DV.
This is because in both cases, the luminance of the OSD elements and the text-based (.srt) subtitles become too high and will hurt your eyes if nothing is done
Awesome, thanks @Portisch
Yes, would be nice to all hdr type.
I changed it for DV + HDR, so check it tomorrow.
2 Likes
This seems to working great for HDR and DV.
Is it possible for this to also be enabled for HLG?
It must be included, yes.
system
Closed
9 June 2024 08:47
10
This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.