Dolby Vision Profile, VS10, plus other info on skins

Unsupported/EOL HW/SW Community Projects
126

The EAC3 with JOC detection is best efforts only - mainly based on looking at BDInfo detection logic and cross referencing the ETSI spec.

That being said this is an odd case either:

  • The 2nd track has something which the logic actually thinks is JOC and hence is Atmos but it is not. - If this is the case then need better logic and maybe will not be fixed, not sure if can test with BDInfo somehow? As switching when later into the track does not have the issue also implies only the start has the false positive.

  • Kodi actually still starts by playing the first track but almost instantly switches over to the 2nd (i.e. the Atmos detection was correct as was on the 1st track to start but need to be reset when moving to the 2nd using the reset mechanism) - I can see possibly a way Atmos would not be reset if using reset and both new and old track are EAC3.

Can put an issue up here so don’t loose track and check when get time:
cpm-code issues

2 Likes
127

Yep, this file sometime false detect.
I havent see similar issue in my files, but what is weird too, its a hdr10+ file, but detected as CMv4 too…

128

There are several films that are DV P7 and HDR10+ on same disk. Could be case here?

129

Its just one video track, no dv track.

130

Implies it has a DV RPU NAL - no other way this gets set, and the Video marked wrong at the container level.

131

Hi @cpm @frodo19

I made a cut of the video using VLC, the original file does indeed contain Dolby Vision.

I just discovered a new issue with the EAC3 display in the Player Info.

I tried with another movie that has Dolby Atmos (EAC3) and made an interesting discovery.

So, I tried the same manipulation on another movie that doesn’t have a Dolby Atmos audio track, only EAC3.

When I switch between audio streams (for example, from audio track 1 to audio track 3, without closing the video), and then open Player Info, sometimes it displays “Dolby Atmos (eac3),” even though there is no Atmos audio track.

You have to constantly change the audio track to trigger this bug. I’m not sure if I’m being clear.

I found this bug using the Arctic Zephyr 2 skin by @frodo19 . I checked the code.

<value condition="String.IsEqual(VideoPlayer.AudioCodec,eac3) + String.Contains(Player.Process(audio.is.dolby.atmos),Atmos)">Dolby Atmos (eac3)</value>

Then I tried with a different code, but the bug is still there, it changes nothing.

<value condition="String.IsEqual(VideoPlayer.AudioCodec,eac3) + String.IsEqual(Player.Process(audio.is.dolby.atmos),Atmos)">Dolby Atmos (eac3)</value>

Here is the video file that does not have a Dolby Atmos audio track: 196.96 MB file on MEGA

Sorry once again for the VLC conversion, there’s a slight signal loss at the beginning of the video. :sweat_smile:

132

It doesn’t depend on that variable. Its equal. Both can work or not work.
Maybe cpm will find a solution.

1 Like
133

Thank you so much for the skin!
Can I ask if it is possible to align the PlayerProcessInfo data a bit more to the right? in my language (italian) the title overlaps in a couple of information.

IMG_9423
IMG_94234032×3024 1.46 MB

134

eac3 does not mean it’s Atmos. eac3 can be 5.1

You need to test for ‘JOC’

135

I know. I’m getting Dolby Atmos (EAC3) as information in the Player Info even though there is no Atmos track on this movie.

EAC3 information in the Player Info is incorrect for now.

136

EDIT: VERSION UPDATE HERE

Button mapping script to toggle VS10 Engine On/Off

Attached is a script to turn VS10 conversion on/off mapped to a remote button. It simply toggles the Kodi Settings > System > CoreELEC > For SDR8, SDR10, HDR10, HDR10+, HLG between off and the previous value. The on screen notification is anchored to the SDR8 value. The current video has to be stopped and restarted for the VS10 change to take effect.

To have the script only toggle a subset of these, comment out what you don’t want toggled. For example to only toggle SDR8 and SDR10

SETTINGS = [
    "coreelec.amlogic.dolbyvision.vs10.sdr8",
    "coreelec.amlogic.dolbyvision.vs10.sdr10",
    #"coreelec.amlogic.dolbyvision.vs10.hdr10",
    #"coreelec.amlogic.dolbyvision.vs10.hdr10plus",
    #"coreelec.amlogic.dolbyvision.vs10.hdrhlg",
    #"coreelec.amlogic.dolbyvision.vs10.dv"
]

  1. Open Keymap Editor Kodi Addon, and map minimise to the remote button you want to use to toggle VS10 on/off
    Edit > Global > System > Minimise > Edit key
    Save

  2. Open SSH and edit gen.xml
    CoreELEC:~ # nano /storage/.kodi/userdata/keymaps/gen.xml

    Find the remote button assigned to shutdown.

    >shutdown</key>

    Change it to:

    >runscript(/storage/.kodi/userdata/keymaps/toggle_vs10.py)</key>

    Save (ctrl+s) and exit (ctrl+x) nano editor

  3. Copy toggle_vs10.py (2.9 KB) to:

    Samba userdata/keymaps/toggle_vs10.py
    (/storage/.kodi/userdata/keymaps/toggle_vs10.py)

  4. Restart Kodi

I didn’t see a way to map a script directly with Keymap Editor, so I don’t know if this process can be simplified. I’m sure the script can be improved, but it does what I need as it is now.

6 Likes
137

Cool, thanks.
The direct access to settings page, not possible?
I mean click the button and go to: Kodi Settings > System > CoreELEC
Maybe would be easyer.
And we can build one togglebutton to the skin, video OSD…
But you are right, after settings page , need navigate back…

138

Is it possible to enhance this script and directly add the stop / resume procedure?

139

Yeah it may be easier for most to map a button to the settings page. The script was mostly for me, but I saw a couple people interested in toggling VS10 engine directly so I shared it.

I’m sure it’s possible, if someone else doesn’t do it, I can make an attempt when I have time.

140

Since I see there’s been quite a discussion about this specific subject, could somebody “in the know” help me understand if Dolby Digital Plus with Atmos is now identifiable as different from DD+ without Atmos? I am asking due to this:

https://forum.kodi.tv/showthread.php?tid=373441

Does the version of Kodi in CoreELEC already incorporate this functionality?
Thanks.

141

not fully, I don’t think you’ll get any extra Atmos identification info in media tags in the library, but this info is available during playback in the PlayerProcessInfo dialog in CPM’s build (WIP atm)

142

Currently, there is an issue with the detection of EAC3 and Dolby Atmos (EAC3) in the Player Info.

I have reported the problem to cpm.

143

Yes, in your samples.
My library working good, no issues, but I havent similar files. :slightly_smiling_face:

144

I actually would want to bitstream DD+ Atmos but not regular DD+, in order to use Auro3D up mixing.

145

A reliable detection must work correctly with all types of files. :sweat_smile:

My files are standard (the original versions), they just have multiple audio tracks.