Missing inputstream.adaptive.so version symlink?

sdt · 8 July 2019 05:56

I remotely run a CoreELEC box for my parents.

Before delivering it to them, I’d installed the Kayo plugin, which uses inputstream.adaptive, and it all worked just fine.

It wasn’t until a few weeks later that they tried it, and got nothing. Digging around in the logs I found:

NOTICE: VideoPlayer::OpenFile: plugin://plugin.video.kayo.sports/?_=play&id=72635&play_type=0&start_from=1238&_l=.pvr
NOTICE: Creating InputStream
ERROR: ADDON: Could not locate inputstream.adaptive.so.2.3.21
ERROR: IAddonInstanceHandler::CreateInstance: inputstream.adaptive returned bad status "Permanent failure" during instance creation
ERROR: CVideoPlayer::OpenInputStream - error opening [plugin://plugin.video.kayo.sports/?_=play&id=72635&play_type=0&start_from=1238&_l=.pvr]
NOTICE: CVideoPlayer::OnExit()

Further digging showed that inputstream.adaptive had updated from v2.3.21 to v2.3.22.

Restarting Kodi fixed this, but this is an always-on box, and I’d like it to be able to pick up these shared library upgrades automatically. (These are the current logs - I’d also had the same problem with a previous version bump)

My main Kodi box is a NUC running the official PPA .deb packages. It too is always-on, but I haven’t had these problems. One difference is that the deb packaged version has symlinks like so:

inputstream.adaptive.so -> inputstream.adaptive.so.18.2
inputstream.adaptive.so.18.2 -> inputstream.adaptive.so.2.3.22
inputstream.adaptive.so.2.3.22

I’m not entirely sure what the idea of the 18.2 symlink is, but I wonder if the CoreELEC packaged inputstream.adaptive should have a similar set of symlinks, or even just:

inputstream.adaptive.so -> inputstream.adaptive.so.2.3.22

This looks like a likely place to add it:

github.com

CoreELEC/CoreELEC/blob/75d74bb2a3c3460f6dba4925da8fc3c981fb95f7/packages/mediacenter/kodi-binary-addons/inputstream.adaptive/package.mk#L25


PKG_LONGDESC="inputstream.adaptive"

PKG_IS_ADDON="yes"

if [ "$TARGET_ARCH" = "x86_64" ] || [ "$TARGET_ARCH" = "arm" ]; then
  PKG_DEPENDS_TARGET="$PKG_DEPENDS_TARGET nss"
fi

addon() {
  install_binary_addon $PKG_ADDON_ID

  mkdir -p $ADDON_BUILD/$PKG_ADDON_ID
  cp -P $PKG_BUILD/.$TARGET_NAME/wvdecrypter/libssd_wv.so $ADDON_BUILD/$PKG_ADDON_ID
}

The only prior art I can find is in /usr/lib/kodi/addons/peripheral.joystick, which has:

peripheral.joystick.so -> peripheral.joystick.so.18.3
peripheral.joystick.so.1.4.7
peripheral.joystick.so.18.3 -> peripheral.joystick.so.1.4.7

I’m really not sure what the correct fix is here.

sdt · 9 July 2019 01:20

Looks like this is an upstream issue. I’ll ask there.

github.com

LibreELEC/LibreELEC.tv/blob/master/packages/mediacenter/kodi-binary-addons/inputstream.adaptive/package.mk

# SPDX-License-Identifier: GPL-2.0
# Copyright (C) 2016-present Team LibreELEC (https://libreelec.tv)

PKG_NAME="inputstream.adaptive"
PKG_VERSION="2.5.5-Matrix"
PKG_SHA256="fd989e0f9f3a032b0263dcb5bb6ccd245a77782e24aaba03571edfeb95f4be5f"
PKG_REV="1"
PKG_ARCH="any"
PKG_LICENSE="GPL"
PKG_SITE="https://github.com/peak3d/inputstream.adaptive"
PKG_URL="https://github.com/peak3d/inputstream.adaptive/archive/$PKG_VERSION.tar.gz"
PKG_DEPENDS_TARGET="toolchain kodi-platform"
PKG_SECTION=""
PKG_SHORTDESC="inputstream.adaptive"
PKG_LONGDESC="inputstream.adaptive"

PKG_IS_ADDON="yes"

if [ "$TARGET_ARCH" = "x86_64" ] || [ "$TARGET_ARCH" = "arm" ]; then
  PKG_DEPENDS_TARGET="$PKG_DEPENDS_TARGET nss"

This file has been truncated. show original

vpeter · 9 July 2019 06:48

Symbolic links are not supported in ZIP for Kodi.

sdt · 11 July 2019 02:23

7za doesn’t support symbolic links, but (surprisingly) zip -y does.

Either way, that doesn’t seem to fix it. I tried creating those symbolic links manually, and the problem persists.

I’m digging around in here now: https://github.com/xbmc/xbmc/blob/master/xbmc/addons/binary-addons/AddonDll.cpp#L75 (code-quoted because it seems I’m not allowed to post github links)

Trying to work out why it keeps trying to load the old version after an update. I have an easy repro at least.