Please ignore the color deviation of the mobile phone photo, and carefully look at the color of the Chinese and English subtitles in the picture, you can know that the subtitle color is wrong
Android Kodi 21.2/22 /Coreelec-no 22/Coreelec-ng 21.2 subtitles are wrong colors
Windows Kodi 21.2/22 /MPV/Potplayer subtitles are correct
Test sample with subtitles
It may be related to whether the subtitles are displayed in the BT2020 color space
I don’t know the code, I searched and it might be related to the link below
master ← thexai:gui-tonemap-setting
opened 08:18AM - 04 Oct 22 UTC
## Description
Adds new setting to set the GUI peak luminance when the display … is in HDR PQ mode
## Motivation and context
This is a follow-up of https://github.com/xbmc/xbmc/pull/18984
While a fixed value of 100 nits should be mathematically correct, there are several reasons to prefer adjust it: different user preferences, perception that the OSD is less bright in HDR than SDR (compared to video), HDR subtitles too bright, differences in the TVs settings, etc.
Default value of 60% it is slightly brighter than before and can be adjusted from slightly less bright than before (0%) to much brighter than before (100%).
Changes can be seen in real time by tapping on the setting while HDR playback is on.
## How has this been tested?
Runtime on Intel NUC8i3BEK
## What is the effect on users?
Being able to calibrate GUI and subtitles luminance in HDR to match same luminance that SDR or adjust for a higher brightness level if desired.
## Screenshots (if appropriate):
## Types of change
- [ ] **Bug fix** (non-breaking change which fixes an issue)
- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)
- [ ] **Improvement** (non-breaking change which improves existing functionality)
- [X] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)
- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)
- [ ] **None of the above** (please explain below)
## Checklist:
- [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project
- [ ] My change requires a change to the documentation, either Doxygen or wiki
- [ ] I have updated the documentation accordingly
- [X] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document
- [ ] I have added tests to cover my change
- [ ] All new and existing tests passed
master ← thexai:android-gui-sdr-peak
opened 06:18PM - 24 Feb 24 UTC
## Description
[Android] Adjust GUI SRD peak luminance when display is in HDR P… Q mode
This the equivalent functionality of https://github.com/xbmc/xbmc/pull/18984 and https://github.com/xbmc/xbmc/pull/21973 for Android.
## Motivation and context
This is requested a lot on the forums....
https://forum.kodi.tv/showthread.php?tid=376360
https://forum.kodi.tv/showthread.php?tid=357205
https://www.reddit.com/r/kodi/comments/1awb6h3/osd_hdr_too_bright_during_playback/
With this is not necessary set subtitles color dark grey or different color for SDR / HDR and also is adjusted OSD and all GUI elements.
Android already does basic tone mapping - there is no need for full tone mapping from BT.709 to BT.2020 or gamma to PQ transfer. Only is need to set the SDR peak to 100 or 200 nits because by default it seems to be set to 1000 nits (at least in Shiled) and this is why it looks much brighter than normal SDR.
When SDR peak is set to 100 - 200 nits then GUI has same appearance than in SDR and GUI white is regular SDR white.
The default setting is 40% and matches what we already have in Windows. That is, the result is consistent with Windows using the same setting value. Adjusting GUI setting to 100% gives you the maximum brightness (~1000 nits), which is the same as before this PR.
## How has this been tested?
Runtime Shield Pro 2019
Forum users:
- Fire TV Stick 4K Max 2nd gen (https://forum.kodi.tv/showthread.php?tid=376360&pid=3186614#pid3186614)
- Fire TV Stick 4K Max 1st gen (https://forum.kodi.tv/showthread.php?tid=376360&pid=3186768#pid3186768)
## What is the effect on users?
No more tricks to adjust brightness of subtitles / OSD / GUI when playing HDR10 or Dolby Vision contents.
## Screenshots (if appropriate):
## Types of change
- [ ] **Bug fix** (non-breaking change which fixes an issue)
- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)
- [ ] **Improvement** (non-breaking change which improves existing functionality)
- [X] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)
- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)
- [ ] **Student submission** (PR was done for educational purposes and will be treated as such)
- [ ] **None of the above** (please explain below)
## Checklist:
- [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project
- [ ] My change requires a change to the documentation, either Doxygen or wiki
- [ ] I have updated the documentation accordingly
- [X] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document
- [ ] I have added tests to cover my change
- [ ] All new and existing tests passed
master ← thexai:gui-hdr
opened 04:29PM - 26 Dec 20 UTC
## Description
- Tonemap Kodi GUI to HDR PQ while in playback of HDR pass-throu… gh mode.
- Fixes very bright OSD, subtitles, etc. and wrong color space (oversaturated).
## Motivation and Context
While in playback HDR pass-through Windows color space is switched to HDR PQ and since Kodi GUI is still SRD, the colors and brightness are totally altered.
SDR GUI (BT.709) needs to be "tone mapped" to HDR color space (BT.2020) and from Gamma transfer to PQ transfer. In this way it is achieved that the Kodi GUI has a peak brightness of 100 nits while the video HDR content can have a peak brightness of 1000 nits for example. PQ uses an absolute scale, so the normal pure white (SDR) must still have 100 nits maximum on the PQ scale and all over 100 nits to 10000 nits is HDR range...
In other words: the GUI will still look the same as when in SDR mode.
## How Has This Been Tested?
Runtime tested on Intel NUC8i3BEK
Also some forum users are testing in https://forum.kodi.tv/showthread.php?tid=359366
## Types of change
- [X] **Bug fix** (non-breaking change which fixes an issue)
- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)
- [X] **Improvement** (non-breaking change which improves existing functionality)
- [X] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)
- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)
- [ ] **None of the above** (please explain below)
## Checklist:
- [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project
- [ ] My change requires a change to the documentation, either Doxygen or wiki
- [ ] I have updated the documentation accordingly
- [X] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document
- [ ] I have added tests to cover my change
- [ ] All new and existing tests passed
master ← kasper93:subs_o
opened 06:33PM - 16 Sep 23 UTC
Target frame parameters were used instead of source frame.
Also for HDR video… s it seems that subtitles target SDR white, so set that too.
Big thanks
