Interesting DV

bluesea · 28 March 2023 23:57

WOW, great CE team, kudos to you guys, thank you!

Portisch · 29 March 2023 18:30

Next step…

djnice · 30 March 2023 06:24

Could you publish a beta test version? I could help you a lot in handling the different Profiles and CM versions (5, 8, 7 MEL, 7 FEL, CMv2.9, CMv4.0). Also, it would be nice to be able to switch between the two types of Dolby Vision output (LLDV 12 bit YUV, Std-DV 8 bit RGB).

Portisch · 30 March 2023 08:21

We are working hard on the implementation itself right now. It’s way to early for a public test image.
This process will require some more steps until we are able to release something.

rome1931 · 30 March 2023 08:44

This might be useful when quietvoid finish.

github.com/xbmc/xbmc

[depends][Android] Add base dependencies setup for libdovi

xbmc:master ← quietvoid:libdovi

opened 07:24PM - 21 Jan 23 UTC

quietvoid

+310 -1

## Description The changes bring support for the Rust toolchain with the goal o…f being able to integrate C compatible dependencies through [cargo-c](https://github.com/lu-zero/cargo-c). This PR also adds the optional [libdovi](https://github.com/quietvoid/dovi_tool/tree/main/dolby_vision) dependency for Android builds. ## Motivation and context The main motivation for this is to be able to convert Dolby Vision on-the-fly, so that Android devices have less issues. This requires `libdovi` (which is a Rust/C compatible library). There are also other usecases for Rust such as binary addons, which seem to have been previously proposed GSoC projects. ## How has this been tested? Tested successful build for all Android target platforms. Runtime tested on FireTV Stick 4K (2018) and 4K Max (2021), so `armv7`. ## What is the effect on users? None by default, as the added dependencies are built optionally with a configure flag. Only the build process is affected, it's still unknown to me how the new dependencies behave on all supported platforms. As the dependencies are limited to Android only, I don't think it can have a negative effect. Testing thread for Android: https://forum.kodi.tv/showthread.php?tid=371557 ## Types of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality) - [ ] **Improvement** (non-breaking change which improves existing functionality) - [x] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that will cause existing functionality to change) - [ ] **Cosmetic change** (non-breaking change that doesn't touch code) - [ ] **None of the above** (please explain below) ## Checklist: - [x] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project - [ ] My change requires a change to the documentation, either Doxygen or wiki - [ ] I have updated the documentation accordingly - [x] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document - [ ] I have added tests to cover my change - [ ] All new and existing tests passed

frodo19 · 30 March 2023 09:02

Yes, I think it’s very good, useful feature , that you can switch off independently of each other, the HDR+, and the DV playing, manually in the Kodi.

Portisch · 30 March 2023 09:29

We will have no possibility to convert DV to like HDR10.
The stream itself does need to have the fallback data otherwise you get strange colours.

There will be a option to disable DV usage at all, but when system support it, it should be enabled as default.

rome1931 · 30 March 2023 10:07

His code enables you play profile 7 Fel by not sending the enhancement layer to the decoder. No conversion to HDR10.

bluesea · 30 March 2023 10:55

Include these 2 PRs?

github.com/xbmc/xbmc

[Android] improve Dolby Vision compatibility

xbmc:master ← thexai:dovi-compatibility

opened 10:11AM - 30 Mar 23 UTC

thexai

+31 -3

## Description Improve Dolby Vision compatibility ## Motivation and context … Follow up of https://github.com/xbmc/xbmc/pull/22950 While the previous PR improved the compatibility of profiles 4 and 5 with devices that do not have a DV display, it has also caused regressions with Dolby Vision profiles 7, 8 and devices that normally work well with HDR10 fallback. This is very important use case as all BD remuxes that come from commercial UHD Blu-Ray's has DV profile 7 with HDR10 fallback (or profile 8 if it has been converted with some tool). See https://github.com/xbmc/xbmc/pull/22950#issuecomment-1487557156 and https://github.com/xbmc/xbmc/pull/22950#issuecomment-1489127003 ## How has this been tested? Not yet ## What is the effect on users? Improve Dolby Vision compatibility with devices that are not DV capable but has HDR10 capabilities. At same time maintains the improvements of the previous PR for devices that are capable of HW tone mapping Dolby Vision profile 4, 5 to SDR. ## Screenshots (if appropriate): ## Types of change - [X] **Bug fix** (non-breaking change which fixes an issue) - [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality) - [X] **Improvement** (non-breaking change which improves existing functionality) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that will cause existing functionality to change) - [ ] **Cosmetic change** (non-breaking change that doesn't touch code) - [ ] **None of the above** (please explain below) ## Checklist: - [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project - [ ] My change requires a change to the documentation, either Doxygen or wiki - [ ] I have updated the documentation accordingly - [X] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document - [ ] I have added tests to cover my change - [ ] All new and existing tests passed

github.com/xbmc/xbmc

[Android] Use dolby-vision codec if supported by the device

xbmc:master ← joseluismarti:mediacodec-dovi

opened 11:13PM - 09 Mar 23 UTC

joseluismarti

+1 -1

## Description If the Android device supports the dolby-vision codec, perhaps w…e should use it for this type of content even if the TV does not support this format. In tests I have done with my TV that supports HDR, HDR 10+ and HLG but not Dolby and Amazon Fire TV Stick 4K Max: Before the change this type of content was played with the hevc codec (`OMX.MTK.VIDEO.DECODER.HEVC`) and now it uses the dolby-vision codec (`OMX.MTK.VIDEO.DECODER.DVHE.STN`), although the picture quality is similar in both cases. Add this PR in case someone wants to test with this or another device. ## Types of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality) - [X] **Improvement** (non-breaking change which improves existing functionality) - [ ] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that will cause existing functionality to change) - [ ] **Cosmetic change** (non-breaking change that doesn't touch code) - [ ] **None of the above** (please explain below) ## Checklist: - [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project - [ ] My change requires a change to the documentation, either Doxygen or wiki - [ ] I have updated the documentation accordingly - [X] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document - [ ] I have added tests to cover my change - [ ] All new and existing tests passed

Blackie · 30 March 2023 11:24

This will be huge if you succeed, thank you for your commitment…
Will the DV support be limited to Homatics or you plan also support for other DV-compatible boxes (ugoos, minix, …) in the future ?

Portisch · 30 March 2023 11:34

Only DV licensed devices, currently only one SC2.
And only devices what do support Amlogic kernel minimum 5.4.180, Amlogic-ne.

mattmarsden · 30 March 2023 11:35

Will this support the full FEL or just the rpu in the FEL?

rome1931 · 30 March 2023 11:47

With quietvoid builds under android just rpu.

djnice · 30 March 2023 12:42

Dolby Vision test patterns: [link]

mattmarsden · 30 March 2023 13:29

Ah OK and I presume this uses the same DV kernel so it will process the same as android.

selfcontained · 30 March 2023 15:25

Can someone explain what this means? Only using the RPU from FEL? How is that different from DV HDR profile 8.1?

Adam86 · 30 March 2023 15:40

I know SC2 refers to S905X4 devices, does that mean that SOC as a whole is licensed for DV or is it further restricted/complicated than that?

I currently have Vontar X4.

emveepee · 30 March 2023 16:18

Does it work in Android? My ah21x devices don’t in fact they even have working Dolby audio.

mattmarsden · 30 March 2023 16:29

Its basically the same as profile 8.1

frodo19 · 30 March 2023 16:40

Its really good for lot of the boxes, whitch have no dv profile 7 support, under android . In this way you cannot see the black screen, or purple, green tint , the box play correct as dolby vision, and convert the profile 7 on the fly to P8.1, and not fallback to hdr . Plus there is the feature, in the Kodi you can choose, that the Dv, Hdr10 plus or hdr video want playing from the hybrid dv/HDR+ mkvs.
https://github.com/quietvoid/xbmc/releases/tag/v21-dovi