I’m wondering if it would make sense to add a couple of patches from OSMC to CE. They look kinda useful
From a356fb5242d419106a1a31ab1f2e9e3aa9ebfafa Mon Sep 17 00:00:00 2001
From: popcornmix <popcornmix@gmail.com>
Date: Sat, 13 Dec 2014 18:35:20 +0000
Subject: [PATCH] Avoid memcpy on every demuxer packet
Avoids an unnecessary memcpy on every demuxer packet which for
high bitrate videos can be significant.
---
xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxFFmpeg.cpp | 17 ++++++++++++-----
xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxUtils.cpp | 9 +++++++--
xbmc/cores/VideoPlayer/Interface/Addon/DemuxPacket.h | 3 +++
3 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxFFmpeg.cpp b/xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxFFmpeg.cpp
index 39108d2..de2f6d2 100644
--- a/xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxFFmpeg.cpp
+++ b/xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxFFmpeg.cpp
@@ -966,7 +966,7 @@ DemuxPacket* CDVDDemuxFFmpeg::Read()
{
if(m_pkt.pkt.stream_index == (int)m_pFormatContext->programs[m_program]->stream_index[i])
show original
From 1f5e34ed5809754b0ec5ed135a487e44c5b68c4e Mon Sep 17 00:00:00 2001
From: tanio99 <tanio99@wolke7.net>
Date: Sun, 1 Sep 2019 09:56:32 +0200
Subject: [PATCH 5/7] avoid flooding the AMLCodec with empty packets (solves
the BD seamless branching problem)
---
xbmc/cores/VideoPlayer/DVDCodecs/Video/DVDVideoCodecAmlogic.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/xbmc/cores/VideoPlayer/DVDCodecs/Video/DVDVideoCodecAmlogic.cpp b/xbmc/cores/VideoPlayer/DVDCodecs/Video/DVDVideoCodecAmlogic.cpp
index 14e11b3..3eac6f9 100644
--- a/xbmc/cores/VideoPlayer/DVDCodecs/Video/DVDVideoCodecAmlogic.cpp
+++ b/xbmc/cores/VideoPlayer/DVDCodecs/Video/DVDVideoCodecAmlogic.cpp
@@ -317,6 +317,9 @@ bool CDVDVideoCodecAmlogic::AddData(const DemuxPacket &packet)
uint8_t *pData(packet.pData);
int iSize(packet.iSize);
+ if (iSize == 0) // we ignore empty packets
+ return true;
show original
I’m running a build with those patches applied, didn’t notice any issues.
Thanks for pointing these out. However, I’m not inclined to add patches, unless they are a clear fix for a known problem, or a worth while improvement. Adding patches as simple as it sounds, tends to add work for the developers in the long run, since once included they need to be maintained. Though if you feel like these make a worth while difference, I can take a look at them.
edit: I also moved the your post since it was technically off topic in the other thread.
