Nightly builds (NEW)

Do I just create a pull request with the same changes against the Leia branch?

Thanks I appreciate you taking the time to look at this :+1:

Well it would be good if you can test it before doing a PR.

I can build and test a Windows version of Kodi, that’s how I initially created the fix, but I can’t build CoreELEC… I’ve tried numerous times in the past and never managed to successfully get CoreELEC to build for me :frowning:

That’s fine. If you can confirm this works on Leia as intended I can make a CE build for you and we can have it merged.

I keep having crashing problems with the latest nightly with the N2. This time I tried to resume a movie from my library over an SMB share. The screen just dimmed but playback never started. After some time, Kodi returned to the main menu and showed me the changes of the latest installed nightly (20200731) which means it totally crashed.

I don’t see anything particularly strange in the crash log itself.
https://paste.kodi.tv/uvikukadif.kodi

Please update to the latest stable release (9.2.4), which is more up to date than the latest nightly.
If the problem is reproducible on stable please post a debug log.

@roidy I have backported your PR to CoreELEC and included it into the testbuild. I also partly reverted: https://github.com/xbmc/xbmc/commit/cb8b7f9b4fa0437ad184b5170f065333e44c5b51

This results in 2 testbuilds (ending with part1 and part2) for you. the fanartres thing should be fixed in both but test both for the original issue so we can debug it further.
https://mega.nz/folder/IxJSUQoI#KO1gy9orGOpZomwHqWd0vw

1 Like

@Ray Thanks, after testing I can confirm that the fanartres fix works perfectly in both parts 1 and 2.

The ReplaceWindow bug remains in part1 but is fixed in part2.

Again thanks for taking the time to look at this.

@roidy Great I will push the patch for fanartres.
About the original issues. It is this “if”:
https://github.com/xbmc/xbmc/blob/cb8b7f9b4fa0437ad184b5170f065333e44c5b51/xbmc/windows/GUIMediaWindow.cpp#L571

Can you please test part2 build if it still solves:

@Ray Ok, after testing I don’t think it does fix the problem from that issue.

I’ve created a simple context menu addon to test with:- add-on removed (see updated version below)

From any movie in the library section bringing up the context menu and using the new option *** ActivateWindow *** simply calls

ActivateWindow(Videos,videodb://movies/actors,return)

To move you into the actors section, now the problem in the above issue is that pressing back returns you to the librarys parent node and not node you called it from. This is the exact behaviour when using your test part1.

Now using your test2 build when pressing back after using the context menu item you are returned to the home page and not the calling node. I think the initial issue is that you should be returned to calling node.

@Ray Umm… Actually I don’t think my addon is a valid test of this issue after reading this in the code comments:-

// If we are activating
// the same window but with a different path, do nothing - we are simply adding to the
// window history.

My add-on does exactly that, call the same window with a new path…

I’m unsure how to test this issue, with out creating an add-on that creates it’s own windows.

@Ray, Ok so I can test it by moving from the Video library to the Music library by changing the addon to use

ActivateWindow(Music,musicdb://artists/,return)

And your test2 build does work as intended.

  1. Enter movie library.
  2. Activate Context menu to move to music library.
  3. Press back and correctly return to movie library.

:+1:

Heres the new addon if you want to do your own testing:- context.activatewindow_test.zip (5.9 KB)

Thanks, I’ll try to reproduce it with the official skin then.
Which separate items should be included in debug logging?

OK so you are confirming that the changes in part2 build fixes all issues?

Yes going by the description of the issue from #16492 then as I understand it it does fix both the original issue and the ReplaceWindow issue.

Ok I guess since it is a partly revert and you confirm it working I think there is no harm adding a patch.
So I will add the partly revert patch and also your fanartres patch. But right now I need to do an emergency 9.2.4.1 release.

1 Like

Thanks, no rush, when ever you get the time :+1:

I think you can continue using part2 build for now cause it is based on 9.2.4.

1 Like

I’ve read CE supports HDR10+ so set it up (nightly_20200731) on my box H96MaxX3+ (S905X3 SoC). I tried several HDR10+ videos but all of them are playing as simple HDR, this one for example https://mega.nz/file/cu5xCLRL#YFt1AeBJ8y9Gh-kx1j_Gr0uwTitypP491_Pvb9B2bac
Did I miss something?

Did you try with setting HDR to SDR to “Auto” and reboot after change ?