20230905 Omega Nightly version
Is the same problem on other platforms?
No problem on other platforms.
It’s broken because of this PR:
xbmc:master ← thexai:sink-names
opened 11:34AM - 22 Aug 23 UTC
## Description
- Improves `CAESinkFactory::ParseDevice` returning values in a s… truct instead parameters by reference. Also avoids use same "device" parameter as input/output which is confusing and requires make a copy to avoids get overwrited in some places.
- Appends sink friendly name to sink string when is different from sink name. e.g:
Before
`WASAPI:{B12C1A75-F8A8-4071-8CFB-A285C619CCB8}`
After
`WASAPI:{B12C1A75-F8A8-4071-8CFB-A285C619CCB8}:HDMI - DENON-AVR (NVIDIA High Definition Audio)`
- When open sink by name (GUID in Windows) and exact match not found, fallback using friendly name.
- Saved settings are not modified unless user opens audio settings.
- When user opens audio settings current device name is "upgraded" and saved in settings, adding friendly name if available.
- Even if current device GUID not exist in system anymore, current setting is not lost because fallback to a device with same friendly name and saved as current "new" device.
- Fixes https://github.com/xbmc/xbmc/issues/21852
## Motivation and context
On Windows sink names are GUIDs and these may change sporadically with Windows Updates or audio drivers updates. When this happens, current logic is fallback to first audio device in list and this breaks passthrough probably because changes from `WASAPI:x` to `DIRECTSOUND:y`
For some users this is just a Kodi bug "Kodi changes sporadically to DIRECTSOUND and breaks passthrough". See https://github.com/xbmc/xbmc/issues/21852 and https://github.com/xbmc/xbmc/issues/22021
Or in forum: https://forum.kodi.tv/showthread.php?tid=373640 or https://forum.kodi.tv/showthread.php?tid=372205
This PR appends friendly device name to setting and, in this way, if GUID changes, same device can be still referenced by friendly name e.g.:
Device saved in settings is:
`WASAPI:{B12C1A75-F8A8-4071-8CFB-A285C619CCB8}:HDMI - DENON-AVR (NVIDIA High Definition Audio)`
But current system device is:
`WASAPI:{555C1A75-F8A8-4071-8CFB-A285C619CCB8}:HDMI - DENON-AVR (NVIDIA High Definition Audio)`
Kodi can continue operate in this way and saved setting is not altered but a WARNING log message warns of this situation.
When the user realizes (if it happens) he can fix it in settings and if not, nothing happens... the next time the user enters in settings it will fix itself for the simple fact that the current setting has changed and the settings are saved when changes.
Since the current setting can only be one of the list and in the list there are only the devices that currently exist in the system.
After this, "new" saved setting is:
`WASAPI:{555C1A75-F8A8-4071-8CFB-A285C619CCB8}:HDMI - DENON-AVR (NVIDIA High Definition Audio)`
And the warning message in the logs disappears.
All this is designed for backward compatibility, that is, it is not mandatory that the settings have the friendly name. And it is also not expected that the audio device will change by the fact of starting to use Kodi with these changes nor is it expected any significant change in the operation except the improvement when the same exact device does not exist.
Even in the case that the setting does not (yet) have the friendly name there are some improvements in the logic: it will always be preferred to change to a device of the same driver first e.g. from `WASAPI:x` to `WASAPI:default` instead of switching to the first random device (DIRECTSOUND).
Please review commits separately as has useful descriptions.
## How has this been tested?
Runtime tested Windows x64 also in Shield (to look for side effects)
## What is the effect on users?
Avoids in some systems sporadically audio device settings are lost because Windows Updates or audio drivers updates.
In general it improves (much) the fallback logic when the current audio device is not available.
## Screenshots (if appropriate):
## Types of change
- [X] **Bug fix** (non-breaking change which fixes an issue)
- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)
- [X] **Improvement** (non-breaking change which improves existing functionality)
- [ ] **New feature** (non-breaking change which adds functionality)
- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)
- [ ] **Cosmetic change** (non-breaking change that doesn't touch code)
- [ ] **Student submission** (PR was done for educational purposes and will be treated as such)
- [ ] **None of the above** (please explain below)
## Checklist:
- [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project
- [ ] My change requires a change to the documentation, either Doxygen or wiki
- [ ] I have updated the documentation accordingly
- [X] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document
- [ ] I have added tests to cover my change
- [ ] All new and existing tests passed
I just reverted it until it’s fixed again.
2 Likes
joco
6 September 2023 19:14
2268
thanks for the revert.
Thanks, now 20230907 Ne Omega Nightly version with alsa aml-augesound HDMI-MULTI CH PCM and Alsa AML-AUGESOUND HDMI HDMI Audio Passthrough Working
frodo19
8 September 2023 15:17
2271
Hi, I trying to mod my own skin, to display on the kodi home, if the internet connection available or not. (not the local connection state)windows kodi, or in android kodi this info valid: $INFO[System.InternetState] This is true/false on connection, and additional busy, if this condition is not available.CoreELEC, there is one patch , which remove this info, and therefore in the kodi cannot show.
thx
hav
12 September 2023 20:58
2272
I tried to install in the internal memory of my t95w2 (s905w2) the image CoreELEC-Amlogic-ne.aarch64-20.3-Nexus_nightly_20230909-Generic.img and what can be seen in the images has happened. Can anyone help me?dtb.img.gz (51.6 KB)http://ix.io/4F0l
hav:
Can anyone help me?
It is recommended that you do a fresh internal installation of your Android box and upgrade to the latest version online.
freddy
13 September 2023 02:54
2275
You allready have a.arch 64
Log tells you that
Try renew options
Once you are in single boot
Plus you are trying to install a nightly on top of old version from August 10…
Best listen to
Remove CoreELEC from internal
Maybe test new versions CoreELEC from external media…
Happy Testing
In SSH terminal after fresh boot
journalctl -l | paste
Your device does not support Dolby Vision, so it is not recommended to use ne brush bag, it is recommended to use ng brush bag.
Vasco
13 September 2023 08:04
2277
I don’t know what you mean with brush bag but that’s incorrect. ne should be used in all supported devices, not only those that have DV capabilities.
hav
13 September 2023 10:18
2279
I still do not quite understand what has happened. Please could you explain?
vpeter
13 September 2023 10:28
2280
Please stop giving advice on a topic you don’t understand because message about playback is just for playback and has nothing to do with Dolby Vision.
Please post the output of:…
parse-android-dynparts /dev/super
hav
14 September 2023 10:01
2283
We have reinstalled Android and then we have put the build of day 11 in the internal memory, without any problem. We have reinstalled Android and then we have put the build of day 11 in the internal memory, without any problem. Thanks for the help.
